Version 2.0.0

Waves 2.0.0

Context

This MR removes the compatibility with python 2 and adds the capability to easily link another code to waves using CMake, as well as a feature to read results from the disk.

Changes

• Remove all import from the future libs of python, the code is now compatible with python 3 only
• Add a waves-config file allowing to easily find and link waves to another code using CMake
• Add a load method to GmshImport to read results from the disk (restart/checkpoint feature)
• Add a UnitTest class to test the classes and methods in tbox which can not be accessed directly through python
• Rename katropton to katoptron, although this was done in !59 (merged), it was not referenced by a tag
• Various minor cleaning and bugfixing

Comments

• The GmshImport and GmshExport classes need to be upgraded to deal with gmsh format 4, as well as to read and write data in binary
• The new method GmshImport::load contains a lot of repeated code, similarly to GmshExport::save, there might be a way to improve this

Tests

Passed on ubuntu20.04 (python 3.8.2), and msys2 (python 3.8.1).

added cleaning enhancement labels

added 1 commit

• 666917cd - Update README

Compare with previous version

added 2 commits

• 0f055922 - Update README
• 4886b32c - Add read results from disk (restart) feature. Add UnitTest. Bugfixes

Compare with previous version

added 1 commit

• 640e2cb8 - format

Compare with previous version

unmarked as a Work In Progress

changed the description

Visual Studio:

• The build produces several warnings related to signed/unsigned integers (as before).
• Tests all pass successfully

macOS / clang:

The build produces interesting warnings related to missing override keyword:

In file included from /Users/rboman/dev/waves/tbox/_src/tboxw.h:31:
/Users/rboman/dev/waves/tbox/src/wFct2.h:134:18: 
  warning: 'write' overrides a member function but is not marked 'override'
      [-Winconsistent-missing-override]
    virtual void write(std::ostream &out) const;
                 ^
/Users/rboman/dev/waves/tbox/src/wFct2.h:100:18: 
  note: overridden virtual function is here
    virtual void write(std::ostream &out) const;

I need to reinstall numpy/matplotlib to run the tests

The tests also work on mac with clang and python 3.7.8!

Nice catch! I wonder why VS and GCC do not issue that warning for that specific case.

clang looks very smart although it is often used in a stupid environment

Do you plan to merge the work of Amaury Bilocq?

Probably in version 2.1.0, because he does not have the time to refactor right now. I will also add my thesis in the future, as well as Xavier Naa's work (if it works).

The header is duplicated

Corrected. By the way, do we need to keep the init.py in python3?

I think so. Each package should have one. I don't think things have changed with python3

Ok!

Do you really need shared pointers to UnitTest objects?

As of now, no and I don't think it will be required in the future. I will make it inherit from wObject instead.

changed this line in version 5 of the diff

As far as I am concerned it is OK.

approved this merge request

added 1 commit

• 9e44b8c1 - Cleaning useless shared_ptr, missing override, virtual destructor

Compare with previous version

approved this merge request

This looks good to me. Thanks!

approved this merge request

Thanks!

merged