Skip to content
Snippets Groups Projects

[feature] New module sky_model with Reinhart sky discretization scheme, water balance correction in GrasSim

Merged Bouvry Arnaud requested to merge release-v1.2.0 into main

[1.2.0] 2025-03-19

Light

  • Reinhart sky discretization scheme is in a new module sky_model in a new class ReinhartSky. Its only input is multiplying factor MF, that is used to multiply the 145 patches from the "original" Tregenza sky subdivision scheme into as many patches (e.g. MF = 4 subdivides each of the patches of the Tregenza scheme in 4). Only the top patch is not subdivided like the others, but its size decreases as MF increases.

  • Conversion function from spherical to cartesian coordinates is in new file conversion_functions.py. Inputs are documented in the function docstring. Conversion functions should be stored there and reused as much as possible to reduce risks of errors.

Crops

  • Clip minimal water content to zero. It was clipped to wilting point, which underestimates drought

Misc

  • Function to save crop yield as csv

Contributors

Merge request reports

Approved by

Merged by Bouvry ArnaudBouvry Arnaud 1 month ago (Mar 20, 2025 8:06am UTC)

Merge details

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading