Resolve "[fix] Gras-Sim compute_N_plant_litter"

See merge request !39

Missing parenthesis at compute_N_plant_litter() call in the daily loop

[feature] Gras-Sim model doctrings

See merge request !38

Resolve "[hotfix] The call of JavaStics doesn't work on Windows"

See merge request !37

It has been fixed by changing the calling of JavaStics as recommended in the documentation.html file from the doc folder you can have by downloading a version JavaStics on the inrae website.

Merge branch '128-hotfix-the-visualization-methods-for-the-crop-models-don-t-work-anymore-because-of-126' into 'develop'

Resolve "[hotfix] The visualization methods for the crop models don't work anymore because of #126"

See merge request !36

The visualization of the the crop models outputs didn't work anymore because of the homogenization of the crop outputs. Creation of a function in run_crop_simulations to resolve this.

Resolve "[feature] Refactor crop models outputs - homogenize"

See merge request !34

Lemaire Louis authored 1 week ago and Bruhwyler Roxane committed 1 week ago

Refactoring of the crop models outputs structure to homogenize.

Merge branch '127-hotfix-error-in-main-and-example-files-in-the-call-of-get_light_maps' into 'develop'

Resolve "[hotfix] Error in main and example files in the call of get_light_maps()"

See merge request !35

Switch the two last arguments in the call of get_light_maps() in main.py and example.py to keyword arguments.

Merge branch '55-feature-put-the-vizualisation-function-show_light_map-into-the-data_management-folder-file' into 'develop'

Improve the genericity of the 3D visualization of results with pyvista

n/a

Merge branch '116-feature-add-tregenza-sky-discretization-scheme-and-optionnal-bre-cie' into 'develop'

Resolve "[feature] Add Tregenza/Reinhart sky discretization scheme"

See merge request !23

* Reinhart sky discretization scheme is in a new module sky_model in a new class ReinhartSky. 
Its only input is multiplying factor MF, that is used to multiply the 145 patches from the "original" Tregenza sky subdivision scheme into as many patches (e.g. MF = 4 subdivides each of the patches of the Tregenza scheme in 4). 
Only the top patch is not subdivided like the others, but its size decreases as MF increases.

* Conversion function from spherical to cartesian coordinates is in new file conversion_functions.py.
Inputs are documented in the function docstring.
Conversion functions should be stored there and reused as much as possible to reduce risks of errors.


Closes #116

Resolve "[feature] APV central visualization early in the main script", closes #87

See merge request !31

[feature] Temporary - crop yield map display in a conditional and automate crop yield display as last simulation year

The input of the function used to display results in the main and example scripts is not called identically for the different crop models, so I put a conditional to avoid having to manually adapt the scripts every time we switch crop models.

Also automatically select the last simulation year to display the crop yield, based on the parameters dictionary. Until now, it was hard coded. It made it so the user could run into an error when the hard-coded year did not match the time range of the simulation. Advanced users can still edit the date of the yield map display as needed.

* Display the APV central before the light computations
* set ground opacity to 0.5 to make it easier to inspect the 3D scene
* add X (East), Y (North) and Z (Zenith) axes on the PyVista render

Resolve "[feature] Save time series of mean variables in a csv file"

See merge request !29

Save mean soil/crop data from a nyears_data dictionnary

The start_year and end_year are related to an Agri4cast csv file and refactoring the whole thing is necessary (just changing the start_year and end_year is not enough). I will create a new issue to better describe the topic.

Merge branch '92-feature-set-start-and-end-year-as-input-parameters-in-get_n_years_daily_wd' into 'develop'

Resolve "[feature] set start and end year as input parameters in get_n_years_daily_WD"

See merge request !27

Merge branch '103-feature-grassim-add-cumulated-sum-of-exported-biomass-to-management-attibutes' into 'develop'

Resolve "[feature] GrasSim: Add cumulated sum of exported biomass to management attibutes"

See merge request !28

Before, the method was working with the hard-coded 2005-2015 year range, which is not at all flexible

Cumulated biomass can now be saved in nyears_data

Resolve "[fix] GrasSim: clip soil water content min value to zero"

See merge request !26

Was clipped to wilting point, which underestimates drought

[fix] days_since_rotation is updated if day is outside of a rotation period.

See merge request !15

Add doctstrings to plant and soil modules. Still lack some arguments types.

Resolve "[feature] Chose crop model in the config file instead of main script"

See merge request !20

Crop config files were passed outside the YAML_inputs_provider and handled differently than other parameter files. This is now fixed.

Field names in the yaml files were also homogenized.

A Definition field was duplicated

[docs] Add partial docstring to MODULES.PHOTOVOLTAICS.production.PV_Production.compute_global_tilted_irradiance

Add partial docstring to MODULES.PHOTOVOLTAICS.production.PV_Production.compute_global_tilted_irradiance to document the inputs (variables and units). Some are still missing and tagged with TODO.

Add doctstrings to Management methods

Add "arg type:" lines

use "Args" for keyword arguments and "Returns" for function output

describe input arguments for initialization of plants and soil.

-

Add docstrings with units

Add function description with variable units