Futurize for python2/3
Context
This merge request brings compatibility for python 3 while ensuring backwards compatibility with python 2.
Details
The future package has been used to futurize the code. Waves can now depend on python3-xxx instead of python-xxx packages.
If python 2 is to be used instead of python 3, proceed with the usual build and add -DUSE_PY3=OFF
to the cmake command line. Note that the additional python-futurize package is required.
Test
Passed on ubuntu18.04 (python 2.7.15 and 3.6.9), debian (gaston, python 2.7), msys2 (python 2.7.16 and 3.8.1)
Merge request reports
Activity
92 94 ENDIF() 93 95 94 96 # -- Search for Python 95 FIND_PACKAGE(PythonInterp 2.7 REQUIRED) 96 FIND_PACKAGE(PythonLibs 2.7 REQUIRED) 97 IF(USE_PY3) 98 SET(pyVersion 3.6) 99 ELSE() 100 SET(pyVersion 2.7) 101 ENDIF() 102 FIND_PACKAGE(PythonInterp ${pyVersion}) 59 61 60 62 # extract some results 61 63 tests = CTests() 62 tests.add(CTest('mean flux X', p.qM.x[0], -11.140748, 1e-4)) 63 tests.add(CTest('mean flux Y', p.qM.x[1], -11.102918, 1e-4)) 64 tests.add(CTest('mean flux X', p.qM.x[0], -12.6239, 1e-4)) - Resolved by Adrien Crovato
Codeowners are working!
Using the latest version of MSYS2 with GCC 9.2 Intel TBB causes new warnings to fire:
- TBB
- atomic.h and mutex.h are deprecated
- fwk/wTimes.cpp
dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] 34 | user = Int64Time(*(reinterpret_cast<__int64 *>(&ftUser)));
- TBB
- Resolved by Adrien Crovato
I had the same new TBB warnings (with many more) when I installed intel mkl/tbb 2020 in the container. As I though that my problems resulted from this new version of tbb/mkl, I downgraded tbb/mkl to 2019.2.
added 7 commits
Toggle commit list