Skip to content
Snippets Groups Projects

Adrien

Merged Adrien
adrien into master
Merged Boman Romain requested to merge adrien into master

Created by: acrovato

Context

This PR brings three new features:

  • mesh data structure and I/O classes in tbox have been reworked
  • VTK is now decoupled from tbox (cfr. issue #25)
  • waves is now partially integrated with Shippable for CI purposes

Test

Built and tested on gaston. Results have been added to testsuite.txt

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Boman Romain
    Boman Romain @rboman started a thread on commit 408f2a10
    • heat/tests/directors/source.py
    28 28 # mesh a unit square
    29 29 pars={ 'Lx' : 1 , 'Ly' : 1, 'Nx' : 50, 'Ny' : 50}
    30 30 msh = gmsh.MeshLoader("../../models/rect_stru.geo",__file__).execute(**pars)
    31 gmshWriter = tbox.GmshExport(msh)
    • Boman Romain
      Boman Romain @rboman ·
      Author Owner

      writer (instead of gmshWriter) would be a better name (so that it is still relevant when another writer is chosen)

  • Boman Romain
    Boman Romain @rboman started a thread on commit 408f2a10
    • tbox/utils.py
    1 #!/usr/bin/env python
    2 # -*- coding: utf-8 -*-
    3 #
    4 # @brief Utilities for tbox
    5 # @authors Adrien Crovato
    6
    7 # @brief Extended range with custom step
    • Boman Romain
      Boman Romain @rboman ·
      Author Owner

      wouldn't it be better to use the python way to write the documentation? (with strings, so that the "help()" command in python still works) At least, does this way work in doxygen?

  • Boman Romain
    Boman Romain @rboman started a thread on commit 408f2a10
    • heat/tests/directors/source.py
    28 28 # mesh a unit square
    29 29 pars={ 'Lx' : 1 , 'Ly' : 1, 'Nx' : 50, 'Ny' : 50}
    30 30 msh = gmsh.MeshLoader("../../models/rect_stru.geo",__file__).execute(**pars)
    31 gmshWriter = tbox.GmshExport(msh)
    • Boman Romain
      Boman Romain @rboman ·
      Author Owner

      Created by: acrovato

      Agreed, but then we would need to add to add a block that switches from gmsh to something else in the code, so it should be part of a greater refactoring.

  • Boman Romain
    Boman Romain @rboman started a thread on commit 408f2a10
    • tbox/utils.py
    1 #!/usr/bin/env python
    2 # -*- coding: utf-8 -*-
    3 #
    4 # @brief Utilities for tbox
    5 # @authors Adrien Crovato
    6
    7 # @brief Extended range with custom step
    • Boman Romain
      Boman Romain @rboman ·
      Author Owner

      Created by: acrovato

      If you type help(utils), you still get the brief and authors. Plus, this can be integrated with doxygen, as you mentionned (I deactivated dox for .py files for now, but it can be enabled).

  • Boman Romain
  • Boman Romain
    Boman Romain @rboman started a thread on commit 408f2a10
    • tbox/utils.py
    1 #!/usr/bin/env python
    2 # -*- coding: utf-8 -*-
    3 #
    4 # @brief Utilities for tbox
    5 # @authors Adrien Crovato
    6
    7 # @brief Extended range with custom step
    Please register or sign in to reply