Skip to content
Snippets Groups Projects

Correction of #23

Merged Boman Romain requested to merge memory_leak_PR into master

Created by: kliegeois

This pull request resolves the bug of the issue #23.

The memory issue was either an issue at the construction or an issue at the destruction of the contacts_list class.

The issue at the construction has been solved not using anymore std::vector of std::vector that generates random issues with gcc (I do not know why).

The issue at the destruction has been solved by allocating the correct size to the contacts_normal Kokkos::view (

n×6n \times 6
instead of
n×3n \times 3
as done previously).

@etphipp this pull request solves the issue related to the email, "Double free memory".

The tests have been tested both with serial ctest and parallel ctest for both release and debug build and several times for each (from 6 to 10 runs to be sure to catch any random behavior) and none of them fails.

This PR includes a commit related to tbox that had an include error that prevents from building with icc.

Merge request reports

Approval is optional

Merged by avatar (Apr 15, 2025 3:26am UTC)

Merge details

  • Changes merged into master with 8360a731.
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading