Correction of compilation warnings

Created by: acrovato

Context and description

This PR consists mainly in cleaning/updating the code. It is linked to issue #5. Additionally the MeshDeformation module now has a linear elasticity mesh deformation method.

Corrected warnings

• Compare int/auto to size_t
• Initialization order
• Unused variables
  • wMshData: int part
  • wHex8, wTetra4: double detJ
  • ctv (in params) ...

Remaining warnings

• Compilation

  • Warning in fwkwPYTHON_wrapp
    • fwk::Time has non virtual destructor and is abstract -> undefined behaviour when deleting
  • Unintialized variables
    • ctv (in params) seed_base

• CMake

CMake Warning (dev) at CMake/FindTBB.cmake:202 (IF):
Policy CMP0054 is not set: Only interpret if() arguments as variables or
keywords when unquoted. Run "cmake --help-policy CMP0054" for policy
details. Use the cmake_policy command to set the policy and suppress this
warning.
Quoted variables like "lib" will no longer be dereferenced when the policy
is set to NEW. Since the policy is not set the OLD behavior will be used.
Call Stack (most recent call first):
tbox/src/CMakeLists.txt:21 (FIND_PACKAGE)
This warning is for project developers. Use -Wno-dev to suppress it.

CMake Deprecation Warning at /usr/share/cmake-3.10/Modules/UseSWIG.cmake:231 (message):
SWIG_ADD_MODULE is deprecated. Use SWIG_ADD_LIBRARY instead.
Call Stack (most recent call first):
params/CVT/_src/CMakeLists.txt:20 (SWIG_ADD_MODULE)

Comments

I would like @rboman to double check the global CMakeLists (some lines need cleaning) and @kliegeois to review the (unused) variables I commented in params/CVT/src/cvt.cpp

Checklist

• Compilation (ubuntu)
• Test (ubuntu)

flow/tests/meshDef.py

@@ -36,7 +36,7 @@ def main():
     msh = gmsh.MeshLoader("../models/n0012.geo",__file__).execute(**pars)
     pbl = f.Problem(msh, alpha0, M_inf, c_ref)
     # create mesh deformation handler
-    mshDef = tbox.MshDeformation(msh, "internalField", ["upstream", "sideUp", "sideLw", "downstream", "airfoil"], ["wakeUp", "wakeLw"])
+    mshDef = tbox.MshDeformation(msh, "internalField", ["upstream", "sideUp", "sideLw", "downstream"], ["airfoil"], ["wakeUp", "wakeLw"])
     # mesh the reference airfoil
     pars = {'xLength' : 5, 'yLength' : 5, 'sEleFar' : 0.5, 'sEleAirfTE' : 0.01, 'sEleAirfLE' : 0.01, 'angle' : alfa}
     msh_ref = gmsh.MeshLoader("../models/n0012rot.geo",__file__).execute(**pars)
@@ -85,7 +85,8 @@ def main():
 
     # deform the mesh (dummy rotation + translation)
     print ccolors.ANSI_BLUE + 'PyDeforming...' + ccolors.ANSI_RESET
-    #mshDef.savePos()
+    u.initMeshDeformer(mshDef)
+    mshDef.savePos()
     rMat = np.matrix([[np.cos(alfa), np.sin(alfa)], [-np.sin(alfa), np.cos(alfa)]])
     i = 0
     size = airfoil.tag.elems.size()
@@ -102,8 +103,7 @@ def main():
         i += 1
     # smooth the mesh
     tms["deform"].start()
-    mshDef.LaplaceSmoothing()
-    #mshDef.DeformElastic()
+    mshDef.deform()
     tms["deform"].stop()
     msh.save("n0012_def.msh")