Skip to content

Update build system for Ubuntu >=20 and Debian >=10 + Heavy cleaning

Boman Romain requested to merge romain into master

This merge request fixes some problems encountered when building NativeSolid on "recent" linux systems where libatlas contains a C-only version of cblas.h and where libopenblas provides a merged library for libcblas.so and libblas.so (#3 has been fixed).

Other changes

The source code has been cleaned:

  • the source code has been properly indented (.editorconfig/.clangformat have been added),
  • using namespace std has been removed,
  • the file structure has been changed so that it is now similar to the other projects (src for the main files; _src for the python wrapper and tests for the tests),
  • relative includes (such as #include "../include/MatVec.h") have been removed,
  • files have been renamed (= class name if a class is defined in the file),
  • virtual / override keywords have been added to some virtual functions,
  • lots of protected sections have been changed to private,
  • some function visibilities have been changed from public to private,
  • lots of other cosmetic changes,
  • README.md has been updated.

New github workflow

A basic gitlab workflow has been created. It builds the code and tests it (it runs TestCVector).

Since there are no other "real" tests; the proposed code has been tested manually in the frame of CUPyDO:

boman@spirou:~/build_scripts/CUPyDO/CUPyDO/CUPyDO/build$ ctest -j 10 -R RBM
Test project /home/boman/build_scripts/CUPyDO/CUPyDO/CUPyDO/build
    Start 26: tests/SU2_RBM/PitchPlungeAirfoil_BGS_parallel_fsi.py
    Start 27: tests/SU2_RBM/PitchPlungeAirfoil_IQN_parallel_fsi.py
    Start 28: tests/SU2_RBM/PitchPlungeN0012_IQN_fsi.py
    Start 25: tests/Flow_RBM/staticNaca_fsi.py
1/4 Test #25: tests/Flow_RBM/staticNaca_fsi.py .......................   Passed    2.19 sec
2/4 Test #28: tests/SU2_RBM/PitchPlungeN0012_IQN_fsi.py ..............   Passed  235.39 sec
3/4 Test #27: tests/SU2_RBM/PitchPlungeAirfoil_IQN_parallel_fsi.py ...   Passed  657.96 sec
4/4 Test #26: tests/SU2_RBM/PitchPlungeAirfoil_BGS_parallel_fsi.py ...   Passed  671.12 sec

100% tests passed, 0 tests failed out of 4

Merge request reports