From aa5ce9620424f20f93c42c4583693187b8492eae Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Maltez=20Cavalheiro=20K=C3=A9vin?=
 <k.maltez@student.uliege.be>
Date: Mon, 5 Aug 2024 10:55:32 +0000
Subject: [PATCH] Update boundaryElements.cpp

Fixed a bug where there were two nested loops on variable i.
---
 srcs/BEM/boundaryElements.cpp | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcs/BEM/boundaryElements.cpp b/srcs/BEM/boundaryElements.cpp
index 54dd80a..7ca2ff1 100644
--- a/srcs/BEM/boundaryElements.cpp
+++ b/srcs/BEM/boundaryElements.cpp
@@ -77,7 +77,7 @@ std::size_t fillElementVector(std::vector<elementStruct> &elementVector,
         // tags and nodes tags) in gmsh.
         std::vector<int> entityTags;
         gmsh::model::getEntitiesForPhysicalGroup(physicalGroupDim, physicalGroupTag, entityTags);
-        for (std::size_t i = 0; i < entityTags.size(); i++)
+        for (std::size_t entity = 0; entity < entityTags.size(); entity++)
         {
             std::vector<int> elementTypes = {1, 8}; // Hardcoded types of 2/3-nodes 1D elements.
             for(std::size_t j = 0; j < elementTypes.size(); j++)
@@ -89,14 +89,14 @@ std::size_t fillElementVector(std::vector<elementStruct> &elementVector,
                 // Get the element tags and the node tags of each element.
                 std::vector<std::size_t> elementTags;
                 std::vector<std::size_t> elementNodeTags;
-                gmsh::model::mesh::getElementsByType(elementTypes[j], elementTags, elementNodeTags, entityTags[i]);
+                gmsh::model::mesh::getElementsByType(elementTypes[j], elementTags, elementNodeTags, entityTags[entity]);
 
                 // Get the coordinates of each node (extracted above).
                 std::vector<std::size_t> nodeTags;
                 std::vector<double> nodeCoords;
                 std::vector<double> parametricNodeCoords;
                 gmsh::model::mesh::getNodesByElementType(elementTypes[j], nodeTags, nodeCoords, parametricNodeCoords,
-                                                         entityTags[i], false);
+                                                         entityTags[entity], false);
 
                 // Constructs a map associating the index of each node tag in the "nodeCoords" vector.
                 std::map<std::size_t, std::size_t> nodeIndices;
-- 
GitLab